Set the icon illustration in the tutorial based on browser #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Firefox, browser extension badges look a bit different and are located in the top right of the icon. This adds new illustrations that better portray the icon in Firefox and sets the illustration shown in the tutorial based on if the browser is Chromium (default) or Firefox. Signed-off-by: sharon-wang <[email protected]>
|
Tested in Chrome, Firefox, and Edge. Firefox has a custom image now as expected, looks great :) |
Signed-off-by: sharon-wang <[email protected]>
|
@vezwork Added illustration for Edge as well. Pls review |
vezwork
approved these changes
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Firefox, browser extension badges look a bit different and are located in the top right of the icon. Edge also has a slightly different look.
This adds new illustrations that better portray the icons in Firefox and Edge, and sets the illustration shown in the tutorial based on if the browser type. Browser detection is now done by checking the user agent string.
Fixes: #55.