Add request for feedback and survey links in popup #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sharon-wang <[email protected]>
vezwork
approved these changes
Apr 4, 2021
There was a problem hiding this comment.
Code LGTM. Tested locally and everything looks good!
- If installing Akita for the first time, the survey popup doesn't show up until the user has spent at least 24 hours of browsing time and then opens Akita (elliot's note: manually changed to 10 seconds to test locally)
- If a user already had Akita installed and has browsed the web for at least 24 hours, then they should see the survey popup the next time they open Akita
- If a user is seeing the survey and they have never streamed payment via WM/Coil, then clicking on the survey link should direct them to the non-WM provider version of the survey
- If a user is seeing the survey and they have used a WM provider/Coil, then clicking on the survey link should direct them to the Coil version of the survey
- Closing the survey via the 'X' in the top right, or clicking
no thanks/maybe latershould dismiss the survey and the survey should never pop up again - If the
Feedbacklink in the header menu is clicked, if the user has never streamed payment via WM/Coil, then clicking on the survey link should direct them to the non-WM provider version of the survey - If the
Feedbacklink in the header menu is clicked, if the user has used a WM provider/Coil, then clicking on the survey link should direct them to the Coil version of the survey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the feedback popup view described in #121 and closes #121.
The survey link provided will either be the survey for those who are using Coil, or the survey for those without a WM provider. This is determined by checking if the user has ever streamed payment via WM while Akita has been installed.
Test cases
no thanks/maybe latershould dismiss the survey and the survey should never pop up againFeedbacklink in the header menu is clicked, if the user has never streamed payment via WM/Coil, then clicking on the survey link should direct them to the non-WM provider version of the surveyFeedbacklink in the header menu is clicked, if the user has used a WM provider/Coil, then clicking on the survey link should direct them to the Coil version of the survey@vezwork pls test functionality with a WM Provider installed.