Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Smack 4.1.0-beta1 #776

Open
wants to merge 4,327 commits into
base: 2.x
Choose a base branch
from
Open

Use Smack 4.1.0-beta1 #776

wants to merge 4,327 commits into from

Conversation

Flowdalic
Copy link

I'd wanted to know how much effort it would be to update Smack in Essentials. Seems pretty easy, but this needs some more testing. Please do not merge until someone else has tested this too.

Especially since Smack 4 is more strict about security, an option to use TLS pinning or to accept all TLS certificates should be considered. But I want to get some feedback from the Essentials developers first before I put more work into it.

SkyBirdSoar and others added 30 commits December 26, 2013 01:17
New changes:
stillwater is an alias to 9:0 (Stationary water)
stilllava is an alias to 11:0 (Stationary lava)
Message permission will allow rough nick matches and wildcards, while pay will only allow wildcards.
Change things so unit testing can run after Bukkit's breaking commit with classloader stuff
Unsafe code is surrounded by sufficient handling
This might effect some plugins which hook Essentials for economy without using the API
khobbits and others added 26 commits July 12, 2014 16:34
…server asked me to do this fix, but I think it is very useful for all. This commit change is to reset player fly & run speed only if player has no permission to change speed.
* Add a method for backwards compatability with unmapped code.
* Convert all getOnlinePlayers() calls to use this method, part of the IEssentials interface
* Add a new method getOnlineUsers() Ljava/lang/Iterable;
* Convert appropriate calls to use this method
* Update Bukkit to #1945
* Update CraftBukkit to #3103
Sticky pistons could break signs that were mounted on blocks the pistons were retracting.

This patch extends the protection from just the piston base to include the extended piston arm and the block at the end of the piston arm as well.

This method will very likely need to be changed again when 1.8 comes out, but this should bring us a bit closer, by wrapping the block tests in a loop.
clarify allow-silent-join-quit
Support aliases in rule and baltop output.
@khobbits
Copy link
Member

In this PR you change the Java version.
We've been running Essentials against Java 6 since the project was created, I'm not sure if we want to change that at the moment.
Maybe when we deicide how which platform to support for 1.8 (I think both spigot and sponge are java7+ only).

@Flowdalic
Copy link
Author

I raised the source/target java level because Smack 4 needs Java 7.

If you think that there is a good reason to still support Java 6. The only reason I can think of is, if you target some unusual JVM, e.g. one for embedded systems, that only supports Java 6. Not sure if this applies to Essentials.

Keep me updated, I stand by to help.

@khobbits
Copy link
Member

Some Minecraft server hosts (the ones that don't really give you access to the server, but let you do things through a webpanel) were still running 1.6 last time we did a review. The same was true of some of the out of the box Linux distributions that some VPS hosts rolled out, when they did install Java.

In the very near future we need to decide what platforms we are going to support going forward, ie if we wan't to release Essentials for Spigot, it will probably make sense to review Java version then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.