source-intercom-native: add tickets stream and reduce logging
#2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tickets` stream is extremely similar to the `conversations` stream; their search endpoints are queried and behave in the same way, so most of this commit was copy + paste of `conversations`, then renaming & refactoring.
Only a single "scroll" can be ongoing at a given time, so it's possible (albeit unlikely) that the capture snapshot test could fail if two applications were running the capture snapshot test.
The connector was logging out `Processing page 1 of 1` frequently when streams were caught up to the present & capturing incrementally. This connector has had sufficient usage that I feel comfortable removing these logs when a stream is caught up, so I limited the page number logging to only happen when a stream is backfilling (i.e. has multiple pages to process or has more than an hour of results to page through).
Alex-Bair
force-pushed
the
bair/source-intercom-native-tickets-stream
branch
from
373abc3 to
43a7e18
Compare
Alex-Bair
changed the title
tickets streamtickets stream and reduce logging
Alex-Bair
added
the
change:unplanned
Alex-Bair
force-pushed
the
bair/source-intercom-native-tickets-stream
branch
from
4662836 to
09bf899
Compare
|
I'm holding off on merging until our production Intercom OAuth app has been updated to request the permissions needed for the |
|
The "Read and List Tickets" permission has been requested for our OAuth app, so I'm going to merge this PR now. If the permission isn't granted until after Intercom's review is complete, we can disable the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR's scope includes:
ticketsstream.ticketsstream is extremely similar to theconversationsstream. Their/{resource}/searchendpoints are queried and behave in the same way, so a good chunk of this PR was copy + paste ofconversations, then renaming & refactoring.config.yamlto not use/companies/scrollfor snapshot testing to avoid possible intermittent failures when running tests.Snapshot changes are expected due to the addition of the
ticketsstream.Our production Intercom OAuth app will need updated to request the "Read and List tickets" permission since the connector needs it to successfully make calls to
/tickets/search. After the OAuth app is updated, any existing tasks will need to be reauthenticated if they want to use theticketsstream.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
Documentation should be updated to reflect the added stream.
We may also want to list what scopes are required if users authenticate with access tokens.Based on Intercom's docs, it sounds like scope/permissions are only applicable to OAuth apps, not access tokens.Notes for reviewers:
Tested on a local stack. Confirmed:
ticketsstream captures data & behaves like theconversationsstream.This change is