Adding the CORS headers to the billing functions #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshearer
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
These changes all LGTM. One question (that I couldn't create inline for some reason) is whether we need to reply with the correct CORS headers in the OPTIONS response as well: https://github.com/estuary/flow/pull/1233/files#diff-8f0dc4f8a45981d5117d609e501af8cc97cdbe842a0418dda9b535326f892b08L17
As it is right now, it appears that Supabase is giving us some CORS headers already, so maybe we're all good:
|
@jshearer - yeah we should. Added the headers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding the CORS headers to the
billingfunctions.Workflow steps:
N/A
Documentation links affected:
N/A
Notes for reviewers:
This is just to be super safe. Everything is working today but we should probably be including these. This especially helps locally when there can be some wonky CORS issues.
This change is