Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

billing: Change to use 10^9 instead of 2^30 #1269

Merged
merged 2 commits into from
Nov 2, 2023
Merged

billing: Change to use 10^9 instead of 2^30 #1269

merged 2 commits into from
Nov 2, 2023

Conversation

jshearer
Copy link
Contributor

@jshearer jshearer commented Nov 1, 2023 •
edited by jgraettinger
Loading

Description:
Update billing calculations to use bytes*10^9, which is the correct definition of "1 Gigabyte", instead of the previous bytes*2^30 which is technically "1 Gibibyte"

Also remove unused billing_report, not to be confused with internal.billing_report_202308

This change is Reviewable

@jshearer
billing: Change to use 10^9 instead of 2^30
1964fe3 
Also remove unused `billing_report`, not to be confused with `internal.billing_report_202308`
@jshearer
Update default data_tiers to $0.50/gb
7329874
jgraettinger
jgraettinger approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jshearer jshearer merged commit 2183ba6 into master Nov 2, 2023
3 checks passed
@jgraettinger jgraettinger deleted the billing/update_to_use_gigabytes branch November 2, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraettinger jgraettinger jgraettinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jshearer @jgraettinger