Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: sql materialization docs updates #1298

Merged
merged 2 commits into from
Dec 1, 2023
Merged

docs: sql materialization docs updates #1298

merged 2 commits into from
Dec 1, 2023

Conversation

williamhbaker
Copy link
Member

@williamhbaker williamhbaker commented Nov 29, 2023

Description:

Small adjustments to SQL materialization docs per estuary/connectors#1086. Also creates basic documentation for materialize-motherduck.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

…ate_sql`

The `additional_table_create_sql` is only for `materialize-postgres` and its variants, and among
those only really useful for `materialize-timescaledb`. It has been removed as a general
configuration for SQL materializations.
@williamhbaker williamhbaker requested a review from dyaffe November 29, 2023 17:59
Copy link

github-actions bot commented Nov 29, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-12-01 20:31 UTC

Copy link
Member

@dyaffe dyaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamhbaker williamhbaker merged commit e9a547f into master Dec 1, 2023
4 checks passed
@williamhbaker williamhbaker deleted the wb/docs-nov29 branch December 1, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants