Phil/cp api updates #1842
Merged
Phil/cp api updates #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two migrations were only ever checked in in order to get reviewed before running them on prod. Neither should be applied to local stacks.
Adds comments to all the publications fields, which get rendered as descriptions in the json schemas.
I realized that I violated a basic rule of api design by not having any sort of type prefix in the path. This hasn't been released yet, so there's no risk of breaking anything important if we change it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolls up a couple of updates:
/api/v1/statusto/api/v1/catalog/statusbecause I realized it was a mistake to not have any sort of type prefix (perhaps we want a data plane status endpoint too?) and this is not yet released so there's no risk of breaking anything if I fix it nowThis change is