Introduce an interval field to capture workflows
#1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
travjenkins
reviewed
Nov 7, 2024
travjenkins
reviewed
Nov 7, 2024
travjenkins
reviewed
Nov 7, 2024
travjenkins
reviewed
Nov 7, 2024
travjenkins
reviewed
Nov 7, 2024
This comment was marked as resolved.
This comment was marked as resolved.
travjenkins
reviewed
Nov 13, 2024
travjenkins
approved these changes
Nov 13, 2024
kiahna-tucker
deleted the
kiahna-tucker/capture-interval/simplify-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are advanced by this PR:
#1194
Changes
1194
The following features are included in this PR:
intervalproperty in capture workflows.Tests
Manually tested
Approaches to testing are as follows:
Validate that the capture interval section does not appear in materialization workflows.
Validate that the capture interval section does not appear in capture workflows when the selected connector does not specify a default capture interval.
Validate that the field is prefilled with the default interval in the capture create workflow when the selected connector specifies one.
Validate that the field is prefilled with the default interval in the capture edit workflow when the live specification does not specify an interval but a default capture interval exists.
Validate that the field is prefilled with the interval specified in the live specification in the capture edit workflow when it exists.
Validate that the field considers input in an unsupported interval format invalid.
Automated tests
Test coverage updated for the following utils:
formatCaptureIntervalPlaywright tests ran locally
Screenshots
Capture interval field | Value selected
Capture interval field | Tooltip
Capture interval field | Predefined interval options
Capture interval field | Empty
Capture interval field-level error