Quick fix for lingering store hydration #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spamming when having network issues. Also, make a more general handler for when there are jwt parsing issues
I am not sure if there is a "real" reason this would happen outside of someone messing with the token.
3 total times before giving up
kiahna-tucker
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Found in slack channel
Changes
Misc
Added a flag of
activeto stores with hydration to store off if the store is being used. This is just a quick fix to prevent store's from being hydrated after the user leaves the pages that use them.Saw an issue with journalData spamming calls during network issues so making that better
Tests
Manually tested
Screenshots