Skip to content

Commit

Permalink
Add support for using package tags/versions in package name (spec)
Browse files Browse the repository at this point in the history
  • Loading branch information
ManasJayanth committed Jul 13, 2024
1 parent 76157fe commit 5bf3a3d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
7 changes: 4 additions & 3 deletions dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -180416,12 +180416,13 @@ function getLatestEsyNPMInfo(alternativeEsyNPMPackage) {
let esyPackage;
if (!alternativeEsyNPMPackage || alternativeEsyNPMPackage === "") {
// No alternative was provided. So, fallback to default
esyPackage = "esy";
esyPackage = "esy@latest";
}
else {
const { validForOldPackages, validForNewPackages, errors = [], } = lib_default()(alternativeEsyNPMPackage);
const [packageName, _packageVersion] = alternativeEsyNPMPackage.split("@");
const { validForOldPackages, validForNewPackages, errors = [], } = lib_default()(packageName);
if (!validForNewPackages || !validForOldPackages) {
throw new Error(`Invalid alternative NPM package name provided: ${alternativeEsyNPMPackage}
throw new Error(`Invalid alternative NPM package name provided: ${packageName}
Errors:
${errors.join("\n")}`);
}
Expand Down
7 changes: 4 additions & 3 deletions index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,16 @@ function getLatestEsyNPMInfo(
let esyPackage;
if (!alternativeEsyNPMPackage || alternativeEsyNPMPackage === "") {
// No alternative was provided. So, fallback to default
esyPackage = "esy";
esyPackage = "esy@latest";
} else {
const [packageName, _packageVersion] = alternativeEsyNPMPackage.split("@");
const {
validForOldPackages,
validForNewPackages,
errors = [],
} = validateNPMPackageName(alternativeEsyNPMPackage);
} = validateNPMPackageName(packageName);
if (!validForNewPackages || !validForOldPackages) {
throw new Error(`Invalid alternative NPM package name provided: ${alternativeEsyNPMPackage}
throw new Error(`Invalid alternative NPM package name provided: ${packageName}
Errors:
${errors.join("\n")}`);
}
Expand Down

0 comments on commit 5bf3a3d

Please sign in to comment.