Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: added a doc for bbolt command-line. #540

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

ishan16696
Copy link
Contributor

This PR adds a document for basic bbolt CLI commands to inspect bbolt database.
Fix: #519

Note:
As mentioned in this comment: #519 (comment) I have not added surgery command in this PR.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for pulling this together @ishan16696. Please see initial suggestions below 🙏🏻

cmd/bbolt/README.md Outdated Show resolved Hide resolved
cmd/bbolt/README.md Outdated Show resolved Hide resolved
cmd/bbolt/README.md Outdated Show resolved Hide resolved
cmd/bbolt/README.md Outdated Show resolved Hide resolved
@ishan16696
Copy link
Contributor Author

Hi @jmhbnz ,
I have addressed all the review comments. PTAL

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ishan16696 - Thanks for making those changes, I think overall this is a great start.

A few more suggestions for you to consider but overall looks pretty good 👍🏻

cmd/bbolt/README.md Outdated Show resolved Hide resolved
cmd/bbolt/README.md Outdated Show resolved Hide resolved
cmd/bbolt/README.md Show resolved Hide resolved
@@ -0,0 +1,374 @@
# Introduction to bbolt command line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we have a mix of bbolt help and additional descriptions of command. Could we improve bbolt help at the same time? Just add the description you added to bbolt help

Copy link
Contributor Author

@ishan16696 ishan16696 Jul 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we improve bbolt help at the same time? Just add the description you added to bbolt help

I didn't get it exactly, should I add a help command for every other command
bbolt <command> -h eg: bbolt info -h , Is this you are asking ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

@ishan16696 ishan16696 Aug 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already mentioned this in help command:

you can use `help` with any command: `bbolt [command] -h` for more information about command.

https://github.com/etcd-io/bbolt/pull/540/files#diff-46e12f11738699c28dd42a6973acce64f7d89f95399d28a611a218dff47f4f9cR59

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it make sense to mention it separately as well ? I have no strong opinion. Either way is fine for me

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ishan16696

cmd/bbolt/README.md Outdated Show resolved Hide resolved
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx @ishan16696

@ahrtr
Copy link
Member

ahrtr commented Aug 1, 2023

The first draft doc is good enough, we can iterate on top of it in separate PRs.

@ahrtr ahrtr merged commit 2478f30 into etcd-io:master Aug 1, 2023
9 checks passed
@ishan16696 ishan16696 deleted the doc/bboltCLI branch August 1, 2023 10:03
@wenjiaswe
Copy link

Thank you @ishan16696 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Documentation for bbolt cli
5 participants