-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: added a doc for bbolt command-line. #540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for pulling this together @ishan16696. Please see initial suggestions below 🙏🏻
Hi @jmhbnz , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ishan16696 - Thanks for making those changes, I think overall this is a great start.
A few more suggestions for you to consider but overall looks pretty good 👍🏻
@@ -0,0 +1,374 @@ | |||
# Introduction to bbolt command line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have a mix of bbolt help
and additional descriptions of command. Could we improve bbolt help
at the same time? Just add the description you added to bbolt help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we improve bbolt help at the same time? Just add the description you added to bbolt help
I didn't get it exactly, should I add a help
command for every other command
bbolt <command> -h
eg: bbolt info -h
, Is this you are asking ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have already mentioned this in help
command:
you can use `help` with any command: `bbolt [command] -h` for more information about command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make sense to mention it separately as well ? I have no strong opinion. Either way is fine for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ishan16696
Signed-off-by: Ishan Tyagi <[email protected]>
eed0419
to
81634ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thx @ishan16696
The first draft doc is good enough, we can iterate on top of it in separate PRs. |
Thank you @ishan16696 ! |
This PR adds a document for basic bbolt CLI commands to inspect bbolt database.
Fix: #519
Note:
As mentioned in this comment: #519 (comment) I have not added
surgery
command in this PR.