Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move checking the invariant properties into a common method #657

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Move checking the invariant properties into a common method #657

merged 1 commit into from
Jan 2, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Dec 31, 2023

Linked to #580

The purposes:

  • to make the common method to be reused by following PR
  • to make the reviewing on the following PR as easy as possible

@ahrtr ahrtr changed the title Move the invariant properties into a common method Move checking the invariant properties into a common method Dec 31, 2023
@Elbehery
Copy link
Member

Elbehery commented Jan 1, 2024

cc @fuweid

fuweid
fuweid approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 9f1a1d3 into etcd-io:main Jan 2, 2024
14 checks passed
@ahrtr ahrtr deleted the refactor_check_20231231 branch June 26, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahrtr @Elbehery @fuweid