tests: remaining errors.Is conversions

[redwrasse]

Remaining errors.Is conversions for the tests directory, as part of #18576.

[k8s-ci-robot]

Hi @redwrasse. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (fd83aba) to head (c42c3c5).

❗ Current head c42c3c5 differs from pull request most recent head bd93a00

Please upload reports for the commit bd93a00 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18618      +/-   ##
==========================================
- Coverage   68.81%   68.79%   -0.02%     
==========================================
  Files         420      420              
  Lines       35522    35522              
==========================================
- Hits        24443    24438       -5     
- Misses       9651     9655       +4     
- Partials     1428     1429       +1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd83aba...bd93a00. Read the comment docs.

[jmhbnz]

/ok-to-test

[henrybear327]

/retest

[ivanvc]

Hi @redwrasse, thanks for your pull request. I think for this PR we may be missing (but correct me if I'm wrong):

• tests/integration/v3_grpc_test.go:1565
• tests/integration/v3_lease_test.go:1089
• tests/integration/clientv3/watch_test.go:812
• tests/integration/clientv3/maintenance_test.go:307

[redwrasse]

Let me add those in, thanks @ivanvc.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, redwrasse

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@redwrasse: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-unit-test-386	bd93a00	link	true	/test pull-etcd-unit-test-386
pull-etcd-integration-1-cpu-amd64	bd93a00	link	true	/test pull-etcd-integration-1-cpu-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[redwrasse]

I must have messed this one up too with a force-push. Will try to fix tomorrow.

[redwrasse]

Opening a new draft PR here #18634 this time won't force push and will squash commits once it's all done.