Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate flag experimental-corrupt-check-time to use corrupt-check-time #19156

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

gangli113
Copy link
Contributor

Fixes: #19141

Move flag experimental-corrupt-check-time

The experimental flags are marked as deprecated and will be decommissioned in v3.7.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @gangli113. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gangli113
Copy link
Contributor Author

/cc @siyuanfoundation

@siyuanfoundation
Copy link
Contributor

/ok-to-test

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.97%. Comparing base (ebb2b06) to head (c6f817e).
Report is 5 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/config.go 79.46% <100.00%> (+0.03%) ⬆️
server/embed/etcd.go 75.86% <100.00%> (ø)
server/etcdmain/config.go 71.42% <100.00%> (+0.37%) ⬆️

... and 14 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19156      +/-   ##
==========================================
+ Coverage   68.83%   68.97%   +0.14%     
==========================================
  Files         420      420              
  Lines       35641    35644       +3     
==========================================
+ Hits        24532    24587      +55     
+ Misses       9687     9646      -41     
+ Partials     1422     1411      -11     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb2b06...c6f817e. Read the comment docs.

@siyuanfoundation
Copy link
Contributor

/retest

@siyuanfoundation
Copy link
Contributor

/lgtm
Thanks for the great work! @gangli113

@siyuanfoundation
Copy link
Contributor

/cc @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Jan 13, 2025

@gangli113 could you please squash the commits and rebase this PR? This PR might conflict with #19148, so please rebase this PR, thx

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 13, 2025
@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

Signed-off-by: Gang Li <[email protected]>

add entry for --corrupt-check-time in help.go

Signed-off-by: Gang Li <[email protected]>

remove a space

Signed-off-by: Gang Li <[email protected]>

fix format

Signed-off-by: Gang Li <[email protected]>

fix cluster.go

Signed-off-by: Gang Li <[email protected]>

Add test in e2e for experimental corrupt check time flag

Signed-off-by: Gang Li <[email protected]>

fix comment

Signed-off-by: Gang Li <[email protected]>

fix comment

Signed-off-by: Gang Li <[email protected]>
@gangli113
Copy link
Contributor Author

@gangli113 could you please squash the commits and rebase this PR? This PR might conflict with #19148, so please rebase this PR, thx

@ahrtr Done. Thank you for the advice.

@gangli113
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, gangli113, serathius, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 5813dce into etcd-io:main Jan 14, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Migrate non-boolean experimental flags in 3.6
5 participants