-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate flag experimental-corrupt-check-time to use corrupt-check-time #19156
Conversation
Hi @gangli113. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 14 files with indirect coverage changes @@ Coverage Diff @@
## main #19156 +/- ##
==========================================
+ Coverage 68.83% 68.97% +0.14%
==========================================
Files 420 420
Lines 35641 35644 +3
==========================================
+ Hits 24532 24587 +55
+ Misses 9687 9646 -41
+ Partials 1422 1411 -11 Continue to review full report in Codecov by Sentry.
|
/retest |
/lgtm |
/cc @ahrtr |
@gangli113 could you please squash the commits and rebase this PR? This PR might conflict with #19148, so please rebase this PR, thx |
New changes are detected. LGTM label has been removed. |
271cf45
to
cecadf2
Compare
cecadf2
to
c4be180
Compare
Signed-off-by: Gang Li <[email protected]> add entry for --corrupt-check-time in help.go Signed-off-by: Gang Li <[email protected]> remove a space Signed-off-by: Gang Li <[email protected]> fix format Signed-off-by: Gang Li <[email protected]> fix cluster.go Signed-off-by: Gang Li <[email protected]> Add test in e2e for experimental corrupt check time flag Signed-off-by: Gang Li <[email protected]> fix comment Signed-off-by: Gang Li <[email protected]> fix comment Signed-off-by: Gang Li <[email protected]>
c4be180
to
f4e7157
Compare
…catedOptions Signed-off-by: Gang Li <[email protected]>
@ahrtr Done. Thank you for the advice. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, gangli113, serathius, siyuanfoundation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #19141
Move flag experimental-corrupt-check-time
The experimental flags are marked as deprecated and will be decommissioned in v3.7.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.