Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix wrong number in comment. #19175

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

jmao-dd
Copy link
Contributor

@jmao-dd jmao-dd commented Jan 11, 2025

The expected sum of weights should be 100, not 1000.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

The expected sum of weights should be 100, not 1000.

Signed-off-by: Jiayin Mao <[email protected]>
@k8s-ci-robot
Copy link

Hi @jmao-dd. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jan 11, 2025

/ok-to-test

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (75f2ae1) to head (5702d87).
Report is 18 commits behind head on main.

Additional details and impacted files

see 29 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19175      +/-   ##
==========================================
+ Coverage   68.74%   68.81%   +0.07%     
==========================================
  Files         420      420              
  Lines       35647    35649       +2     
==========================================
+ Hits        24504    24531      +27     
+ Misses       9713     9695      -18     
+ Partials     1430     1423       -7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f2ae1...5702d87. Read the comment docs.

@jmao-dd
Copy link
Contributor Author

jmao-dd commented Jan 12, 2025

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmao-dd, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit a03bdaa into etcd-io:main Jan 13, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants