Skip to content

Commit

Permalink
Renaming secrets for clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
luxaritas committed Sep 6, 2024
1 parent 54fc71a commit fd033c0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
uses: actions/create-github-app-token@v1
id: engines-app-token
with:
app-id: ${{ secrets.BUILT_ENGINE_CLIENT_ID }}
app-id: ${{ secrets.BUILT_ENGINE_APP_CLIENT_ID }}
private-key: ${{ secrets.BUILT_ENGINE_APP_PRIVATE_KEY }}
owner: eternagame
repositories: eternajs-folding-engines
Expand Down Expand Up @@ -168,7 +168,7 @@ jobs:
brew link --overwrite openssl@3
npm ci
node src/index.js retrieve DEVELOPMENT ${{ secrets.APP_SIGNING_PRIVATE_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }} $CERTIFICATE_PATH $P12_PASSWORD
node src/index.js retrieve DEVELOPMENT ${{ secrets.APPLE_APP_SIGNING_PRIVATE_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }} $CERTIFICATE_PATH $P12_PASSWORD
# create temporary keychain
security create-keychain -p "$KEYCHAIN_PASSWORD" $KEYCHAIN_PATH
security set-keychain-settings -lut 21600 $KEYCHAIN_PATH
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rotate-apple-keys.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@ jobs:
run: npm ci
working-directory: ./.github/workflows/setup-apple-signing
- name: Rotate development key
run: node src/index.js rotate DEVELOPMENT ${{ secrets.APP_SIGNING_PRIVATE_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
run: node src/index.js rotate DEVELOPMENT ${{ secrets.APPLE_APP_SIGNING_PRIVATE_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_BASE64 }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ID }} ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
working-directory: ./.github/workflows/setup-apple-signing

0 comments on commit fd033c0

Please sign in to comment.