Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot API 7.9 #2377

Merged
merged 9 commits into from
Aug 17, 2024
Merged

Bot API 7.9 #2377

merged 9 commits into from
Aug 17, 2024

Conversation

coder2020official
Copy link
Collaborator

@coder2020official coder2020official commented Aug 15, 2024

  • Added support for Super Channels, allowing received channel messages to have users or other channels as their senders.
  • Added the ability to send paid media to any chat.
  • Added the parameter business_connection_id to the method sendPaidMedia, allowing bots to send paid media on behalf of a business account.
  • Added the field paid_media to the class TransactionPartnerUser for transactions involving paid media.
  • Added the method createChatSubscriptionInviteLink, allowing bots to create subscription invite links.
  • Added the method editChatSubscriptionInviteLink, allowing bots to edit the name of subscription invite links.
  • Added the field until_date to the class ChatMemberMember for members with an active subscription.
  • Added support for paid reactions and the class ReactionTypePaid.

@coder2020official
Copy link
Collaborator Author

"Added the field until_date to the class ChatMemberMember for members with an active subscription."
Our chatmember base already has this, no need for commit
but I recommend re-writing chatmember classes

@coder2020official
Copy link
Collaborator Author

First two didn't require a commit either.
@Badiboy done, you may review when you have time to do so

@coder2020official
Copy link
Collaborator Author

@Badiboy any news on this

@Badiboy
Copy link
Collaborator

Badiboy commented Aug 17, 2024

Did not see in tonns of notifications. See now.

Copy link
Collaborator

@Badiboy Badiboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything except "name=name" proposal LGTM.

:rtype: :class:`telebot.types.ChatInviteLink`
"""
return types.ChatInviteLink.de_json(
apihelper.create_chat_subscription_invite_link(self.token, chat_id, subscription_period, subscription_price, name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose to make optional parameters named.
... name=name

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the name?

:rtype: :class:`telebot.types.ChatInviteLink`
"""
return types.ChatInviteLink.de_json(
apihelper.edit_chat_subscription_invite_link(self.token, chat_id, invite_link, name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same here.
name=name

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ASYNC also in 2 places.

@Badiboy
Copy link
Collaborator

Badiboy commented Aug 17, 2024

👍

@Badiboy Badiboy merged commit a27d82c into eternnoir:master Aug 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants