Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect argument type in answer_pre_checkout_query() #2389

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

Relecto
Copy link
Contributor

@Relecto Relecto commented Aug 21, 2024

Hi!
Noticed a typing mistake, it should be fairly easy to fix :)

As per the documentation, in answer_pre_checkout_query method, pre_checkout_query_id should be str, not int - https://core.telegram.org/bots/api#answerprecheckoutquery

Description

Correct type in answer_pre_checkout_query() method signature

Describe your tests

Pycharm does not show type warning anymore :)

Python version: 3.12

OS: MacOS, Debian

Checklist:

  • I added/edited example on new feature/change (if exists)
  • My changes won't break backward compatibility
  • I made changes both for sync and async

@Relecto Relecto marked this pull request as ready for review August 21, 2024 12:16
@Relecto Relecto changed the title Set answer_pre_checkout_query query_id argument type to str Fix incorrect argument type in answer_pre_checkout_query() Aug 21, 2024
@Badiboy
Copy link
Collaborator

Badiboy commented Aug 21, 2024

Thank you.

@Badiboy Badiboy merged commit 04e2bc5 into eternnoir:master Aug 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants