fix: anvil mine #1784
Open
fix: anvil mine #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small refactor so `chain.mine()` works as expected w/ anvil - `chain.mine()` mines 1 block - `chain.mine(x)` mines x blocks
clarify in docs what chain.mine() does
| @@ -2184,13 +2184,11 @@ Chain Methods | |||
| >>> chain.time() | |||
| 1550189143 | |||
|
|
|||
| .. py:method:: Chain.mine(blocks=1, timestamp=None, timedelta=None) | |||
There was a problem hiding this comment.
timestamp and timedelta should still work when using ganache / hardhat so removing the documentation around it feels wrong.
iamdefinitelyahuman
requested changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
small refactor so
chain.mine()works as expected w/ anvilCurrently,
chain.mine()orchain.mine(x)both revert with errorbrownie.exceptions.RPCRequestError: Timestamp error: 1 is lower than or equal to previous block's timestampRelated issue: #
How I did it
set the
minefunction to only useevm_mineand to passblocksinstead of defaulting to hardcoded 1How to verify it
chain.mine()mines 1 blockchain.mine(x)mines x blocksChecklist