add anoter test-case

eth-cscs · May 27, 2024 · 217cf55 · 217cf55
1 parent 8a21233
commit 217cf55
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/test/unit/permutations/test_permutations_distributed.cpp b/test/unit/permutations/test_permutations_distributed.cpp
@@ -190,7 +190,6 @@ void testDistPermutationsAsLocal(comm::CommunicatorGrid& grid, SizeType n, SizeT
   const GlobalElementSize size(n, n);
   const TileElementSize block_size(nb, nb);
   const Index2D src_rank_index(std::max(0, grid.size().rows() - 1), std::min(1, grid.size().cols() - 1));
-
   const Distribution dist(size, block_size, grid.size(), grid.rank(), src_rank_index);
 
   const SizeType max_perms_lc = dist.local_size().get<C>();
@@ -200,6 +199,8 @@ void testDistPermutationsAsLocal(comm::CommunicatorGrid& grid, SizeType n, SizeT
 
   const auto [i_start_el_lc, i_end_el_lc] = tileToElementRange(max_perms_lc, nb, i_begin_lc, i_end_lc);
   const SizeType nperms_lc = i_end_el_lc - i_start_el_lc;
+
+  // Note: create a local "mirror" permutation
   for (SizeType i_window_lc = 0; i_window_lc < nperms_lc; ++i_window_lc)
     perms[to_sizet(i_start_el_lc + i_window_lc)] = nperms_lc - 1 - i_window_lc;
 
@@ -256,9 +257,9 @@ void testDistPermutationsAsLocal(comm::CommunicatorGrid& grid, SizeType n, SizeT
 }
 
 const std::vector<std::tuple<SizeType, SizeType, SizeType, SizeType>> params2 = {
-    {6, 2, 0, 3},
-    {36, 4, 0, 9},
-    {6, 2, 1, 3},
+    {6, 2, 0, 3},  {36, 4, 0, 9},  // full matrix
+    {6, 2, 1, 3},  {36, 4, 2, 7},  // sub-matrix
+    {36, 5, 2, 8},                 // sub-matrix, with last tile incomplete
 };
 
 TYPED_TEST(PermutationsDistTestMC, ColumnsLocal) {
@@ -273,31 +274,33 @@ TYPED_TEST(PermutationsDistTestMC, ColumnsLocal) {
   }
 }
 
-TYPED_TEST(PermutationsDistTestMC, RowsLocal) {
+#ifdef DLAF_WITH_GPU
+TYPED_TEST(PermutationsDistTestGPU, ColumnsLocal) {
   using T = TypeParam;
-  constexpr auto CPU = Device::CPU;
+  constexpr auto GPU = Device::GPU;
 
   for (auto& comm_grid : this->commGrids()) {
     for (const auto& [n, nb, i_begin, i_end] : params2) {
-      testDistPermutationsAsLocal<T, CPU, Coord::Row>(comm_grid, n, nb, i_begin, i_end);
+      testDistPermutationsAsLocal<T, GPU, Coord::Col>(comm_grid, n, nb, i_begin, i_end);
       pika::wait();
     }
   }
 }
+#endif
 
-#ifdef DLAF_WITH_GPU
-TYPED_TEST(PermutationsDistTestGPU, ColumnsLocal) {
+TYPED_TEST(PermutationsDistTestMC, RowsLocal) {
   using T = TypeParam;
-  constexpr auto GPU = Device::GPU;
+  constexpr auto CPU = Device::CPU;
 
   for (auto& comm_grid : this->commGrids()) {
     for (const auto& [n, nb, i_begin, i_end] : params2) {
-      testDistPermutationsAsLocal<T, GPU, Coord::Col>(comm_grid, n, nb, i_begin, i_end);
+      testDistPermutationsAsLocal<T, CPU, Coord::Row>(comm_grid, n, nb, i_begin, i_end);
       pika::wait();
     }
   }
 }
 
+#ifdef DLAF_WITH_GPU
 TYPED_TEST(PermutationsDistTestGPU, RowsLocal) {
   using T = TypeParam;
   constexpr auto GPU = Device::GPU;