First matrix cleanup #1007
Merged
First matrix cleanup #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasolca
force-pushed
the
rasolca/matrix/cleanup
branch
from
d16559d
to
0184583
Compare
rasolca
force-pushed
the
rasolca/matrix/cleanup
branch
from
0184583
to
93893b3
Compare
msimberg
requested changes
Oct 26, 2023
|
cscs-ci run |
|
cscs-ci run |
msimberg
approved these changes
Nov 8, 2023
albestro
reviewed
Nov 15, 2023
Comment on lines
+24
to
+25
| /// which references elements | ||
| /// that are already allocated in the memory with a column major layout. |
There was a problem hiding this comment.
minor: early newline in doc? is it needed?
| /// that are already allocated in the memory with a column major layout. | ||
| /// | ||
| /// @param[in] ld the leading dimension of the matrix, | ||
| /// @param[in] ptr is the pointer to the first element of the local part of the matrix, |
There was a problem hiding this comment.
?
Suggested change
| /// @param[in] ptr is the pointer to the first element of the local part of the matrix, | |
| /// @param[in] ptr is the pointer to the first element of the matrix, |
| return layout_.blockSize(); | ||
| } | ||
|
|
||
| TileElementSize block_size() const noexcept { |
There was a problem hiding this comment.
Should the old one be marked as deprecated?
| /// @pre @p ptr refers to an allocated memory region which can contain the elements of the local matrix | ||
| /// stored in the given layout. | ||
| template <Device D, class T> | ||
| Matrix<T, D> createMatrixFromTile(const LocalElementSize& size, const TileElementSize& block_size, |
There was a problem hiding this comment.
Just an idea: what if we take the chance to give it a better name? createMatrixFromTileLayout would be longer, but less misleading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #976.
See #1006 for details.