Use ubuntu 2024.04 in CI #1140
Merged
Use ubuntu 2024.04 in CI #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
rasolca
force-pushed
the
ci/ubuntu202404
branch
from
ae52df9
to
620d661
Compare
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
rasolca
force-pushed
the
ci/ubuntu202404
branch
from
b535b07
to
daeac85
Compare
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
rasolca
force-pushed
the
ci/ubuntu202404
branch
from
5771565
to
0b97999
Compare
|
cscs-ci run |
rasolca
force-pushed
the
ci/ubuntu202404
branch
from
734a5a1
to
03cf20c
Compare
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
msimberg
approved these changes
Sep 16, 2024
| @@ -43,7 +43,7 @@ TEST(GridTest, GridScaLAPACKOrdering) { | |||
| #endif | |||
|
|
|||
| TEST(GridTest, GridDLAFOrdering) { | |||
| for (const auto [key, value] : ordering) { | |||
| for (const auto& [key, value] : ordering) { | |||
There was a problem hiding this comment.
Just curious, was this a warning or compilation error? Did we miss testing something previously?
There was a problem hiding this comment.
A new warning, IIRC, with clang 18
rasolca
commented
Sep 17, 2024
| @@ -53,7 +53,7 @@ JOB_TEMPLATE=" | |||
| variables: | |||
| SLURM_CPUS_PER_TASK: {{CPUS_PER_TASK}} | |||
| SLURM_NTASKS: {{NTASKS}} | |||
| SLURM_TIMELIMIT: '20:00' | |||
| SLURM_TIMELIMIT: '25:00' | |||
There was a problem hiding this comment.
GPU codecov RANK_6 test hits the limit often during report generation.
Add 5 mins to reduce the chance of this.
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.