Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve release script #1147

Merged
merged 5 commits into from
May 23, 2024
Merged

Improve release script #1147

merged 5 commits into from
May 23, 2024

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented May 22, 2024

  • Add support for HTTPS (alongside SSH) as git operations protocol
  • Add check on git status (no un-committed changes allowed)

For DLA-Future-Fortran I used gh instead of hub used here. gh is an official GitHub product, and can simplify authentication. Do we want to switch to it? See gh-vs-hub for more context.

@RMeli RMeli self-assigned this May 22, 2024
@rasolca
Copy link
Collaborator

rasolca commented May 22, 2024

For the gh vs hub question, I think it is better to have a separate PR.

scripts/roll_release.sh Outdated Show resolved Hide resolved
@RMeli
Copy link
Member Author

RMeli commented May 23, 2024

For the gh vs hub question, I think it is better to have a separate PR.

Do you want me to open the PR and discuss there, or open an issue/discussion?

@rasolca rasolca merged commit 99cfa87 into eth-cscs:master May 23, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request May 23, 2024
@rasolca
Copy link
Collaborator

rasolca commented May 23, 2024

For the gh vs hub question, I think it is better to have a separate PR.

Do you want me to open the PR and discuss there, or open an issue/discussion?

An issue or a discussion during the weekly meeting...

@RMeli RMeli deleted the rmeli/release-script branch May 23, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants