-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup matrix setup in miniapp_triangular_multiplication to enable complex types #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasolca
reviewed
Jun 6, 2024
rasolca
reviewed
Jun 6, 2024
const T alpha = 2.0; | ||
|
||
double m = ah.size().rows(); | ||
double n = bh.size().cols(); | ||
auto add_mul = n * m * m / 2; | ||
const double total_ops = dlaf::total_ops<T>(add_mul, add_mul); | ||
|
||
auto [in_op_a, out_b, in_b] = ::sampleLeftTr(uplo, op, diag, alpha, ah.size().rows()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do you still need it?
rasolca
reviewed
Jun 6, 2024
cscs-ci run |
msimberg
reviewed
Jun 11, 2024
gulivarese
changed the title
Miniapp trmm check
Cleanup matrix setup in miniapp_triangular_multiplication to enable complex types
Jun 12, 2024
cscs-ci run |
rasolca
force-pushed
the
miniapp_trmm_check
branch
from
June 19, 2024 12:42
596347d
to
ef014c9
Compare
msimberg
reviewed
Jul 2, 2024
cscs-ci run |
cscs-ci run |
albestro
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cscs-ci run |
msimberg
approved these changes
Jul 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
…ble complex types (#1160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.