Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup matrix setup in miniapp_triangular_multiplication to enable complex types #1160

Merged
merged 17 commits into from
Jul 8, 2024

Conversation

gulivarese
Copy link
Collaborator

No description provided.

@gulivarese gulivarese requested a review from rasolca June 5, 2024 12:48
@gulivarese gulivarese self-assigned this Jun 5, 2024
const T alpha = 2.0;

double m = ah.size().rows();
double n = bh.size().cols();
auto add_mul = n * m * m / 2;
const double total_ops = dlaf::total_ops<T>(add_mul, add_mul);

auto [in_op_a, out_b, in_b] = ::sampleLeftTr(uplo, op, diag, alpha, ah.size().rows());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you still need it?

@gulivarese
Copy link
Collaborator Author

cscs-ci run

@gulivarese gulivarese changed the title Miniapp trmm check Cleanup matrix setup in miniapp_triangular_multiplication to enable complex types Jun 12, 2024
@gulivarese
Copy link
Collaborator Author

cscs-ci run

@msimberg msimberg marked this pull request as ready for review July 2, 2024 12:38
@rasolca
Copy link
Collaborator

rasolca commented Jul 3, 2024

cscs-ci run

@rasolca
Copy link
Collaborator

rasolca commented Jul 3, 2024

cscs-ci run

Copy link
Collaborator

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rasolca should we wait for #1175 and drop all clang-format workarounds?

@rasolca
Copy link
Collaborator

rasolca commented Jul 4, 2024

cscs-ci run

@rasolca rasolca merged commit 30690ca into master Jul 8, 2024
4 of 5 checks passed
@rasolca rasolca deleted the miniapp_trmm_check branch July 8, 2024 15:38
github-actions bot pushed a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants