Don't use SCOPED_TRACE in test_multiplication_hermitian
#1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run |
msimberg
force-pushed
the
test-hemm-hang
branch
from
60d9814
to
c05613c
Compare
|
cscs-ci run |
msimberg
force-pushed
the
test-hemm-hang
branch
from
c05613c
to
6241686
Compare
|
cscs-ci run |
3 similar comments
|
cscs-ci run |
|
cscs-ci run |
|
cscs-ci run |
msimberg
force-pushed
the
test-hemm-hang
branch
from
05f4c3f
to
e506332
Compare
|
cscs-ci run |
1 similar comment
|
cscs-ci run |
msimberg
force-pushed
the
test-hemm-hang
branch
from
d34bc2d
to
4e8f656
Compare
msimberg
changed the title
test_multiplication_hermitian
msimberg
changed the title
test_multiplication_hermitianSCOPED_TRACE in test_multiplication_hermitian
|
cscs-ci run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pika task may yield while the
SCOPED_TRACEis in scope, and if it resumes on a different thread there will be segfaults. This PR removes the use ofSCOPED_TRACEin that test.It's still unclear what exactly in pika ends up yielding, since it's not expected to yield. That will be investigated separately.
Part of #603.