Support different tile and block size in Matrix
#909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run |
6 tasks
|
Waiting for #898 before I continue here since these will both touch |
msimberg
force-pushed
the
matrix-support-generic-distribution
branch
from
6b32df6
to
301fb44
Compare
|
cscs-ci run |
|
This so far makes some minimal relaxations to allow constructing matrices with different tile size and block size. I've added some tests, but coverage could likely be better. I'm currently only exposing this functionality through the |
rasolca
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving over the changes from #908 (comment) to a separate PR.
Do we want to renameEdit: I haven't done any renamings like this because in some cases we call things likeLayoutInfo::blockSizetoLayoutInfo::tileSize?tileSizecan be equal toblockSizebut more generallyLayoutInfois concerned with the tile size.square_blocksizeand for that we want everything to have ablockSizemethod. I'm punting this down the road.