-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test phase in CI for stdexec configuration #930
Conversation
cscs-ci run |
7c4321b
to
8ec8a1c
Compare
Note: I have a timeout on |
8ec8a1c
to
3e43875
Compare
97e3d63
to
2e6a577
Compare
cscs-ci run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aurianer for the investigation here.
Functionally I'm happy with this change but see inline comment before I'm ready to approve this.
Linking #665 as well since it's a related issue. I think the solution here is necessary, but possibly not sufficient for full control of tile lifetimes (as the remaining ensure_started
problem hints at).
2e6a577
to
088c560
Compare
088c560
to
90bda4a
Compare
cscs-ci run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now, thanks!
I'd still like to wait to see the benchmark results, but assuming there are no surprises there this requires no further changes.
The missing includes from unwrap.h
are not a blocker for this PR.
90bda4a
to
9b8da64
Compare
So I:
TODO: Post the benchmark results when available |
9b8da64
to
975e6d8
Compare
cscs-ci run |
std::tuple
(previously handled by using pika's version ofensure_started
aftertransform
Remove explicit use of futures in tridiagonal solver #658)