Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace thread_manager::wait with pika::wait #968

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Replace thread_manager::wait with pika::wait #968

merged 1 commit into from
Sep 13, 2023

Conversation

msimberg
Copy link
Collaborator

@msimberg msimberg commented Sep 4, 2023

Fixes #957.

@msimberg msimberg added this to the Cleanup milestone Sep 4, 2023
@msimberg msimberg self-assigned this Sep 4, 2023
@msimberg
Copy link
Collaborator Author

msimberg commented Sep 4, 2023

cscs-ci run

aurianer
aurianer approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

spack/packages/dla-future/package.py Outdated Show resolved Hide resolved
@msimberg
Copy link
Collaborator Author

msimberg commented Sep 5, 2023

cscs-ci run

@msimberg
Copy link
Collaborator Author

msimberg commented Sep 5, 2023

Updated SPACK_SHA because the old one only had pika 0.16.0 available (and thus installed pika main as a replacement for 0.17.0).

@msimberg
Copy link
Collaborator Author

msimberg commented Sep 6, 2023

cscs-ci run

@msimberg
Copy link
Collaborator Author

msimberg commented Sep 7, 2023

This is now ready to go.

@rasolca rasolca merged commit d241f41 into eth-cscs:master Sep 13, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@rasolca
Doc Replace thread_manager::wait with pika::wait (#968)
1d445a0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@rasolca rasolca rasolca approved these changes

Assignees

@msimberg msimberg

Labels
None yet
Projects
DLA-F Planning
Archived in project
Milestone
Cleanup
Development

Successfully merging this pull request may close these issues.

Replace pika::threads::get_thread_manager().wait() by pika::wait()
3 participants
@msimberg @rasolca @aurianer