Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HDF5 input and output files to eigensolver miniapp #973

Merged
merged 11 commits into from
Sep 13, 2023
Merged

Add HDF5 input and output files to eigensolver miniapp #973

merged 11 commits into from
Sep 13, 2023

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Sep 7, 2023

Add HDF5 input and output files to eigensolver miniapp.

  • Decide how to call the input matrix dataset
  • Decide how to call the eigenvalues vector dataset
  • Decide how to call the eigenvectors matrix dataset

I used /a temporarily (it's what I had in an HDF5 I'm using), but I'm open to better suggestions. Maybe /input would do.

@RMeli RMeli added Type:New Feature New feature or request Priority:Low labels Sep 7, 2023
RMeli
RMeli commented Sep 7, 2023
View reviewed changes
miniapp/miniapp_eigensolver.cpp Outdated
ConstHostMatrixType matrix_ref = [comm_grid, &opts]() {
#ifdef DLAF_WITH_HDF5
if (opts.input_file) {
Matrix<T, Device::CPU> input = opts.input_file->read<T>("/a", {opts.mb, opts.mb});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Matrix<T, Device::CPU> input = opts.input_file->read<T>("/a", {opts.mb, opts.mb});
Matrix<T, Device::CPU> input = opts.input_file->read<T>("/input", {opts.mb, opts.mb});

?

RMeli
RMeli commented Sep 7, 2023
View reviewed changes
miniapp/miniapp_eigensolver.cpp Outdated Show resolved Hide resolved
This was referenced Sep 7, 2023
Closed
Merged
@RMeli RMeli marked this pull request as draft September 7, 2023 15:04
@RMeli RMeli marked this pull request as ready for review September 7, 2023 15:51
msimberg
msimberg approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

albestro
albestro approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for adapting also the other miniapp. 😉

@rasolca
Copy link
Collaborator

rasolca commented Sep 8, 2023

cscs-ci run

@RMeli
Copy link
Member Author

RMeli commented Sep 12, 2023

cscs-ci run

@RMeli
Copy link
Member Author

RMeli commented Sep 12, 2023

cscs-ci run

@RMeli
Copy link
Member Author

RMeli commented Sep 12, 2023

cscs-ci run

HDF5 doesn't seem to be enabled in CI, is it? I added +hdf5 to the CI specs in #980, where I plan to use it for tests (TBD), but maybe it should be added here already?

@RMeli
Copy link
Member Author

RMeli commented Sep 13, 2023

cscs-ci run

@rasolca rasolca merged commit 1fd315b into eth-cscs:master Sep 13, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@rasolca
Doc Add HDF5 input and output files to eigensolver miniapp (#973)
a3b7d6c
@msimberg msimberg added Type:Bug Something isn't working TODO:Task Category:CI not planned Feature currently outside of the roadmap that might be considered in the future Type:New Feature New feature or request and removed Type:New Feature New feature or request Type:Bug Something isn't working TODO:Task Category:CI not planned Feature currently outside of the roadmap that might be considered in the future labels Sep 27, 2023
@RMeli RMeli deleted the eig-hdf5 branch April 4, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasolca rasolca rasolca approved these changes

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco

@aurianer aurianer Awaiting requested review from aurianer

@albestro albestro Awaiting requested review from albestro

Assignees
No one assigned
Labels
Priority:Low Type:New Feature New feature or request
Projects
DLA-F Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RMeli @rasolca @msimberg @albestro