Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor asynchronous client #107

Merged
merged 11 commits into from
Jun 13, 2024
Merged

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented May 28, 2024

The asynchornous client has been refactored, with a small addition: the merging of requests needs to be enabled manually.

Changes:

  • Add timers in the logs for the asynchronous requests.
  • Locks are kept only for the merging of requests.
  • Merging of requests will not be attempted if the time between calls of the microservice is 0.
  • Merging of requests will not be attempted for /compute/acct when the user is not specifying the jobs IDs or when other parameters are passed (for example page_number or start_time).

Will close #94 .

@ekouts ekouts requested a review from rsarm May 28, 2024 11:32
@ekouts ekouts self-assigned this May 28, 2024
@ekouts ekouts changed the title Refactor async merge reqs add timers of requests in the Refactor asynchronous client May 28, 2024
@ekouts ekouts merged commit 4537886 into eth-cscs:main Jun 13, 2024
8 checks passed
@ekouts ekouts deleted the refactor/async_merge_reqs branch June 13, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncFirecrest: Practicality and Efficiency
2 participants