-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asynchronous client for pyfirecrest #65
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ekouts
commented
Aug 14, 2023
•
edited
Loading
edited
- Latest build of the documentation: https://pyfirecrest--65.org.readthedocs.build/en/65/
- To try you can find a short tutorial in this page.
- Install the new version with:
jpdorsch
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ekouts
added a commit
that referenced
this pull request
Aug 17, 2023
* ✨ Add typing * make upload/download more permissive * apply black * Add types in to documentation * Update types * fix formatting * Add undoc-members in types reference * First implementation of AsyncFirecrest client * Add httpx in the dependencies * Add some basic example for the async client * Set polling rate in example * Fix import * Fix external transfer * Add example for external transfers * Add async external objects in reference * Expose async external objects * Fix issue with mixed responses in case of errors * Get the access token before stalling requests * Add documentation for async client + refactor * Decouple async and sync clients * Split ExternalStorage objects to another file * Fix typo * Fix typo in filename * Refactor status tests * Add auth handler * Refactor compute tests * Refactor extra tests * Refactor reservation tests * Refactor storage tests * Refactor utilities tests * Duplicate compute testing for async version * Add compute tests * Add extra tests for async client * Add reservation async tests + small fixes * Add status tests for async client + small fixes * Add utilities tests + fix async whoami * Add storage tests for async version * Remove unused imports and fix annotation * Small fixes * Fix type errors * Small fix in docs * Remove old installation instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.