Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asynchronous client for pyfirecrest #65

Merged
merged 45 commits into from
Aug 17, 2023
Merged

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented Aug 14, 2023

git clone -b async_client https://github.com/ekouts/pyfirecrest-fork.git pyfirecrest
cd pyfirecrest
# You need an environment of python>=3.7
python -m pip install .

@ekouts ekouts self-assigned this Aug 14, 2023
@ekouts ekouts marked this pull request as ready for review August 14, 2023 08:17
@ekouts ekouts requested a review from jpdorsch August 14, 2023 08:17
Copy link
Collaborator

@jpdorsch jpdorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekouts ekouts merged commit 72bb870 into eth-cscs:main Aug 17, 2023
5 checks passed
@ekouts ekouts deleted the async_client branch August 17, 2023 14:31
ekouts added a commit that referenced this pull request Aug 17, 2023
* ✨ Add typing

* make upload/download more permissive

* apply black

* Add types in to documentation

* Update types

* fix formatting

* Add undoc-members in types reference

* First implementation of AsyncFirecrest client

* Add httpx in the dependencies

* Add some basic example for the async client

* Set polling rate in example

* Fix import

* Fix external transfer

* Add example for external transfers

* Add async external objects in reference

* Expose async external objects

* Fix issue with mixed responses in case of errors

* Get the access token before stalling requests

* Add documentation for async client + refactor

* Decouple async and sync clients

* Split ExternalStorage objects to another file

* Fix typo

* Fix typo in filename

* Refactor status tests

* Add auth handler

* Refactor compute tests

* Refactor extra tests

* Refactor reservation tests

* Refactor storage tests

* Refactor utilities tests

* Duplicate compute testing for async version

* Add compute tests

* Add extra tests for async client

* Add reservation async tests + small fixes

* Add status tests for async client + small fixes

* Add utilities tests + fix async whoami

* Add storage tests for async version

* Remove unused imports and fix annotation

* Small fixes

* Fix type errors

* Small fix in docs

* Remove old installation instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants