Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small bugs in the async client #68

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix small bugs in the async client #68

merged 1 commit into from
Sep 12, 2023

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented Aug 21, 2023

Fixes:

  • After the rate limit for a microservice is reached, the next request should be scheduled after the Retry-After header and the user-imposed rate limit. Both should be respected so we keep the larger value.
  • Change bytes and lines to str (instead of int) in the head and tail commands in the async client, to follow the sync client. In the sync client this was already fixed.
  • Add skip_ending and skip_beginning in head and tail commands respectively, in the async client.
  • Changed the order of bytesand lines arguments in the documentation of head and tail commands, to follow the order of the arguments in the function.

@ekouts ekouts requested a review from jpdorsch August 21, 2023 07:54
@ekouts ekouts self-assigned this Aug 21, 2023
Copy link
Collaborator

@jpdorsch jpdorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekouts ekouts merged commit 4364b35 into eth-cscs:main Sep 12, 2023
5 checks passed
@ekouts ekouts deleted the fixes branch September 12, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants