EnlargedImage: Default alt Attribute to Empty String

ethanselzer · Apr 2, 2018 · 106b31c · 106b31c
1 parent 377c938
commit 106b31c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/EnlargedImage.js b/src/EnlargedImage.js
@@ -183,6 +183,7 @@ export default class extends React.Component {
             isLazyLoaded,
             largeImage,
             largeImage: {
+                alt = '',
                 onLoad = noop,
                 onError = noop
             },
@@ -194,7 +195,7 @@ export default class extends React.Component {
                 style: this.containerStyle
             }}>
                 <img { ...{
-                    alt: largeImage.alt,
+                    alt,
                     className: imageClassName,
                     src: largeImage.src,
                     srcSet: largeImage.srcSet,

diff --git a/test/enlarged-image.spec.js b/test/enlarged-image.spec.js
@@ -117,11 +117,19 @@ describe('Enlarged Image', () => {
         });
 
         it('applies large image alt', () => {
+            shallowWrapper.setProps({ largeImage: {alt: 'foo'}});
+
             const renderedWrapper = shallowWrapper.render();
 
             expect(renderedWrapper.find('img').attr('alt')).to.equal('foo');
         });
 
+        it('defaults large image alt to empty string', () => {
+            const renderedWrapper = shallowWrapper.render();
+
+            expect(renderedWrapper.find('img').attr('alt')).to.equal('');
+        });
+
         it('applies large image src', () => {
             const renderedWrapper = shallowWrapper.render();
 
@@ -506,7 +514,6 @@ describe('Enlarged Image', () => {
         fadeDurationInMs: 0,
         isActive: false,
         largeImage: {
-            alt: 'foo',
             src: 'bar',
             srcSet: 'corge',
             width: 12,