-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnome46 #215
Gnome46 #215
Conversation
* fix reviewdog * make eslint happy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankfully, this time around, the delta is fairly minimal and should be fully backwards compatible.
Looks good! agreed, much smaller delta this time so i'll get this tested today.
But boy oh boy, I sure hate the debugging experience in gnome-shell.
yup.
Note: This is especially interesting with Ubuntu 24.04 just around the corner. If we manage to finally release this update, people could actually use the extension from day one :)
The beta has been released so I'll look into testing this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes seem to work fine on both 23.10 (using X11 and driver 545) and the beta 24.04 version (using X11 and both driver 545 and driver 550). Approving merge!
The only remaining thing to make the 24.04 release as smooth as possible would be the wayland issues - are you able to rebase #214 at some point @kenohassler ? Though 24.04 won't be wayland by default, it would be a nice-to-have.
Thanks a lot Deren! I rebased the other PR, good to go 🙂 |
no problem! thanks for getting this done :) |
This continues the work of #213 for gnome 46. Thankfully, this time around, the delta is fairly minimal and should be fully backwards compatible. But boy oh boy, I sure hate the debugging experience in gnome-shell.
The necessary change is outlined here in the documentation: https://gjs.guide/extensions/upgrading/gnome-shell-46.html#gjs
Note: This is especially interesting with Ubuntu 24.04 just around the corner. If we manage to finally release this update, people could actually use the extension from day one :)