Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnome46 #215

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Gnome46 #215

merged 1 commit into from
Apr 16, 2024

Conversation

kenohassler
Copy link
Collaborator

@kenohassler kenohassler commented Apr 15, 2024

This continues the work of #213 for gnome 46. Thankfully, this time around, the delta is fairly minimal and should be fully backwards compatible. But boy oh boy, I sure hate the debugging experience in gnome-shell.

The necessary change is outlined here in the documentation: https://gjs.guide/extensions/upgrading/gnome-shell-46.html#gjs

Note: This is especially interesting with Ubuntu 24.04 just around the corner. If we manage to finally release this update, people could actually use the extension from day one :)

* fix reviewdog
* make eslint happy
@derenv derenv added needs review Issue/PR needs response/review gnome/GTK Issues/PR's related to GTK version compatibility labels Apr 16, 2024
Copy link
Collaborator

@derenv derenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully, this time around, the delta is fairly minimal and should be fully backwards compatible.

Looks good! agreed, much smaller delta this time so i'll get this tested today.

But boy oh boy, I sure hate the debugging experience in gnome-shell.

yup.

Note: This is especially interesting with Ubuntu 24.04 just around the corner. If we manage to finally release this update, people could actually use the extension from day one :)

The beta has been released so I'll look into testing this too.

@derenv derenv added needs testing PR needs testing in GNOME environment and removed needs review Issue/PR needs response/review labels Apr 16, 2024
Copy link
Collaborator

@derenv derenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem to work fine on both 23.10 (using X11 and driver 545) and the beta 24.04 version (using X11 and both driver 545 and driver 550). Approving merge!

The only remaining thing to make the 24.04 release as smooth as possible would be the wayland issues - are you able to rebase #214 at some point @kenohassler ? Though 24.04 won't be wayland by default, it would be a nice-to-have.

@derenv derenv merged commit 187ccd3 into ethanwharris:master Apr 16, 2024
2 checks passed
@derenv derenv added enhancement and removed needs testing PR needs testing in GNOME environment labels Apr 16, 2024
@kenohassler kenohassler deleted the gnome46 branch April 16, 2024 08:25
@kenohassler
Copy link
Collaborator Author

Thanks a lot Deren! I rebased the other PR, good to go 🙂

@derenv
Copy link
Collaborator

derenv commented Apr 16, 2024

Thanks a lot Deren! I rebased the other PR, good to go 🙂

no problem! thanks for getting this done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement gnome/GTK Issues/PR's related to GTK version compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants