feat: standard l2 genesis #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add design doc
tynes
commented
Oct 5, 2024
| fullfill these deposit transactions. | ||
|
|
||
| The general flow is as follows: | ||
|
|
There was a problem hiding this comment.
One downside to this approach is that it expands the ABI of the L1Block contract, causing every system transaction to consume a bit more gas due to 4 byte selector comparisons in the jumptable. The alternative would be to introduce a new contract that stores these values. Custom gas token is in the L1Block contract already, we cannot remove that ABI due to modifications of the WETH predeploy being used in production, the WETH predeploy is not proxied so it cannot be updated easily
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add design doc for standard L2 genesis