feat: report method name in WS metrics #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkykadir
force-pushed
the
feat/ws-method-name
branch
from
7e1cd82 to
e790296
Compare
|
Hi Mkykadir, Thanks for the contribution! Its a clever solution, however I am concerned about a race condition occurring with concurrent map access w.reqIdToMethod if the proxyd was under heavy ws traffic. I'm curious if you would be able to find a solution that can avoid this? Also please include test cases if possible |
jelias2
requested changes
Jul 26, 2024
|
@jelias2 nice catches actually I missed a crucial point as well:
|
mkykadir
force-pushed
the
feat/ws-method-name
branch
from
454c87f to
d745088
Compare
mkykadir
force-pushed
the
feat/ws-method-name
branch
from
d745088 to
64f854c
Compare
jelias2
reviewed
Jan 8, 2025
| @@ -0,0 +1,56 @@ | |||
| package proxyd | |||
There was a problem hiding this comment.
Some tests for this struct to validate concurrency would nice
jelias2
reviewed
Jan 8, 2025
| res, err := w.parseBackendMsg(msg) | ||
| if res != nil { | ||
| if value, has := idToMethod.GetAndRemove(string(res.ID)); has { |
There was a problem hiding this comment.
Will res.ID be unique? Typically is determined by the request ID with in the rpc, I don't believe its unique among many requests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Access method name in WS context so metrics can be reported with method name