Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] L1 nonce for consensus events (deposits + config updates) #13539

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Dec 27, 2024

Description

Implementation of ethereum-optimism/specs#330 (comment), more details coming soon...

Tracker issue: #13543

Tests

Additional context

Metadata

@mdehoog mdehoog force-pushed the michael/deposit-queue branch 3 times, most recently from bb0c03c to 116598a Compare December 27, 2024 19:54
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 60.29851% with 133 lines in your changes missing coverage. Please review.

Project coverage is 47.18%. Comparing base (2fb8c66) to head (b79d33d).

Files with missing lines Patch % Lines
op-node/rollup/derive/l1_block_info.go 58.82% 18 Missing and 10 partials ⚠️
op-node/rollup/derive/deposit_log.go 40.47% 25 Missing ⚠️
op-service/eth/types.go 0.00% 17 Missing ⚠️
op-chain-ops/genesis/config.go 29.41% 12 Missing ⚠️
op-node/rollup/derive/system_config.go 25.00% 9 Missing ⚠️
op-node/rollup/derive/attributes.go 38.46% 5 Missing and 3 partials ⚠️
op-node/rollup/derive/payload_util.go 0.00% 6 Missing ⚠️
op-node/rollup/sequencing/sequencer.go 0.00% 3 Missing and 1 partial ⚠️
op-node/rollup/types.go 63.63% 4 Missing ⚠️
...kages/contracts-bedrock/src/L1/OptimismPortal2.sol 75.00% 3 Missing and 1 partial ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13539      +/-   ##
===========================================
- Coverage    47.25%   47.18%   -0.07%     
===========================================
  Files          958      961       +3     
  Lines        80075    80264     +189     
  Branches       773      774       +1     
===========================================
+ Hits         37836    37874      +38     
- Misses       39335    39480     +145     
- Partials      2904     2910       +6     
Flag Coverage Δ
cannon-go-tests-32 62.26% <ø> (-1.98%) ⬇️
cannon-go-tests-64 57.35% <ø> (-1.62%) ⬇️
contracts-bedrock-tests 90.75% <85.07%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-batcher/batcher/sync_actions.go 26.80% <ø> (ø)
op-chain-ops/genesis/layer_two.go 0.00% <ø> (ø)
op-chain-ops/interopgen/recipe.go 74.90% <100.00%> (+0.20%) ⬆️
op-node/rollup/chain_spec.go 70.94% <100.00%> (+1.29%) ⬆️
op-node/rollup/derive/deposits.go 71.87% <100.00%> (+1.87%) ⬆️
op-program/client/l2/engineapi/l2_engine_api.go 33.69% <100.00%> (+0.18%) ⬆️
op-service/sources/types.go 66.25% <100.00%> (+0.21%) ⬆️
...contracts-bedrock/src/L1/OptimismPortalInterop.sol 100.00% <100.00%> (+33.33%) ⬆️
.../contracts-bedrock/src/L1/OptimismPortalJovian.sol 100.00% <100.00%> (ø)
...s/contracts-bedrock/src/L1/SystemConfigInterop.sol 76.19% <100.00%> (+9.52%) ⬆️
... and 20 more

... and 23 files with indirect coverage changes

@mdehoog mdehoog force-pushed the michael/deposit-queue branch 14 times, most recently from b299bc9 to b38eac2 Compare December 29, 2024 03:35
@mdehoog mdehoog changed the title [WIP] Deposit queue [WIP] L1 nonce for consensus events (deposits + config updates) Dec 29, 2024
@mdehoog mdehoog force-pushed the michael/deposit-queue branch 11 times, most recently from 48ac835 to 5486868 Compare December 31, 2024 01:06
@mdehoog mdehoog force-pushed the michael/deposit-queue branch 9 times, most recently from fcdf93e to 0d86ad8 Compare January 6, 2025 02:32
@mdehoog mdehoog force-pushed the michael/deposit-queue branch 15 times, most recently from 7f4682e to d33ed21 Compare January 13, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant