Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-node: cluster config #13709

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

op-node: cluster config #13709

wants to merge 1 commit into from

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jan 10, 2025

Description

Tests

Additional context

Metadata

@tynes tynes requested review from a team as code owners January 10, 2025 23:26
@tynes tynes requested a review from protolambda January 10, 2025 23:26
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Project coverage is 45.83%. Comparing base (7719c5a) to head (b1fa5fc).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
op-node/rollup/types.go 15.38% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13709      +/-   ##
===========================================
- Coverage    46.96%   45.83%   -1.14%     
===========================================
  Files          958      901      -57     
  Lines        79963    75203    -4760     
  Branches       766      766              
===========================================
- Hits         37558    34468    -3090     
+ Misses       39560    38018    -1542     
+ Partials      2845     2717     -128     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests 90.64% <ø> (+2.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-node/rollup/types.go 58.15% <15.38%> (-1.36%) ⬇️

... and 81 files with indirect coverage changes

@tynes tynes marked this pull request as draft January 10, 2025 23:40
@@ -254,6 +265,16 @@ func (cfg *Config) CheckL2GenesisBlockHash(ctx context.Context, client L2Client)
return nil
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to call IsDependencySetUpdate in the attributes builder and optionally add a new deposit tx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant