Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop: Add Finality Action Testing #13774

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

axelKingsley
Copy link
Contributor

Adds a Finality Action Test, with two subcases:

  • 0 additional L1 blocks
  • 10 additional L1 blocks

The additional blocks parameter is used to "bury" the L2 under more L1 data. This had been a bug discovered in the Supervisor, in which Finality couldn't be determined, because the L1 was so far ahead from the L2's processing point.

@axelKingsley axelKingsley requested review from a team as code owners January 14, 2025 22:35
@axelKingsley axelKingsley requested a review from geoknee January 14, 2025 22:35
@axelKingsley axelKingsley changed the title Add Finality Action Testing interop: Add Finality Action Testing Jan 14, 2025
@axelKingsley axelKingsley force-pushed the interop-finality-action-tests branch from e273931 to 396f037 Compare January 14, 2025 22:37
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.89%. Comparing base (5f7e31c) to head (396f037).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13774      +/-   ##
===========================================
- Coverage    47.23%   42.89%   -4.35%     
===========================================
  Files          957      791     -166     
  Lines        80028    70659    -9369     
  Branches       758        0     -758     
===========================================
- Hits         37802    30307    -7495     
+ Misses       39318    37711    -1607     
+ Partials      2908     2641     -267     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 173 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant