-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swell (Testnet) #690
base: main
Are you sure you want to change the base?
Add Swell (Testnet) #690
Conversation
677d5b2
to
7db82c9
Compare
7db82c9
to
019e974
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this doesn't apply cleanly to main anymore
just codegen
adds a "governed_by_optimism" flagjust validate 1924
throws some errors:
=== RUN TestValidation/Swellchain_Testnet_(1924)/Data_Availability_Type
data-availability-type_test.go:56:
Error Trace: .../github.com/ethereum-optimism/superchain-registry/validation/data-availability-type_test.go:56
.../github.com/ethereum-optimism/superchain-registry/validation/validation_test.go:44
Error: Received unexpected error:
operation failed permanently after 3 attempts: failed to retrieve previous nonce: missing trie node 486e81dbaf0d082af8a24573c8588c9db1fe72046a2a50fc5938baf82a3a18d0 (path ) state 0x486e81dbaf0d082af8a24573c8588c9db1fe72046a2a50fc5938baf82a3a18d0 is not available
Test: TestValidation/Swellchain_Testnet_(1924)/Data_Availability_Type
Messages: failed when checking chain for recent batcher txs from 0x77C60EfDBDa83410EE0373Eda2ed06891238c93d
--- FAIL: TestValidation/Swellchain_Testnet_(1924)/Data_Availability_Type (3.97s)
019e974
to
9257ae9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing some key addresses from addresses.json
like L1CrossDomainMessenger
. Can you please add these addresses?
@atenjin please see the above |
Adding a New Chain
This PR adds Swell Testnet to the registry.
Checklist
just validate <chain-id>
locally to ensure all local validation checks pass.just codegen
to ensure that the chainlist and other generated files are up-to-date and include my chain.