Skip to content

Commit

Permalink
Merge pull request #3873 from jtraglia/nits-in-7594-p2p-interface
Browse files Browse the repository at this point in the history
Fix nits in eip7594 p2p-interface spec
  • Loading branch information
hwwhww authored Aug 8, 2024
2 parents 674d924 + 5409396 commit bd396a6
Showing 1 changed file with 15 additions and 16 deletions.
31 changes: 15 additions & 16 deletions specs/_features/eip7594/p2p-interface.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,18 @@

### Preset

| Name | Value | Description |
| - | - | - |
| Name | Value | Description |
|-----------------------------------------|-------------------------------------------------------------------------------------------|-------------------------------------------------------------------|
| `KZG_COMMITMENTS_INCLUSION_PROOF_DEPTH` | `uint64(floorlog2(get_generalized_index(BeaconBlockBody, 'blob_kzg_commitments')))` (= 4) | <!-- predefined --> Merkle proof index for `blob_kzg_commitments` |


### Configuration

*[New in Deneb:EIP4844]*
*[New in EIP7594]*

| Name | Value | Description |
|------------------------------------------|-----------------------------------|---------------------------------------------------------------------|
| `MAX_REQUEST_DATA_COLUMN_SIDECARS` | `MAX_REQUEST_BLOCKS_DENEB * NUMBER_OF_COLUMNS` | Maximum number of data column sidecars in a single request |
| `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS` | `2**12` (= 4096 epochs, ~18 days) | The minimum epoch range over which a node must serve data column sidecars |
| Name | Value | Description |
|------------------------------------------------|------------------------------------------------|---------------------------------------------------------------------------|
| `MAX_REQUEST_DATA_COLUMN_SIDECARS` | `MAX_REQUEST_BLOCKS_DENEB * NUMBER_OF_COLUMNS` | Maximum number of data column sidecars in a single request |
| `MIN_EPOCHS_FOR_DATA_COLUMN_SIDECARS_REQUESTS` | `2**12` (= 4096 epochs, ~18 days) | The minimum epoch range over which a node must serve data column sidecars |

### Containers

Expand Down Expand Up @@ -180,8 +179,8 @@ The `<context-bytes>` field is calculated as `context = compute_fork_digest(fork

[1]: # (eth2spec: skip)

| `fork_version` | Chunk SSZ type |
| - | - |
| `fork_version` | Chunk SSZ type |
|------------------------|-----------------------------|
| `EIP7594_FORK_VERSION` | `eip7594.DataColumnSidecar` |

Request Content:
Expand Down Expand Up @@ -228,9 +227,9 @@ The `<context-bytes>` field is calculated as `context = compute_fork_digest(fork

[1]: # (eth2spec: skip)

| `fork_version` | Chunk SSZ type |
|--------------------------|-------------------------------|
| `EIP7594_FORK_VERSION` | `eip7594.DataColumnSidecar` |
| `fork_version` | Chunk SSZ type |
|------------------------|-----------------------------|
| `EIP7594_FORK_VERSION` | `eip7594.DataColumnSidecar` |

Request Content:
```
Expand Down Expand Up @@ -323,6 +322,6 @@ Requests the MetaData of a peer, using the new `MetaData` definition given above

A new field is added to the ENR under the key `csc` to facilitate custody data column discovery.

| Key | Value |
|:------|:-----------------------------------------|
| `csc` | Custody subnet count, big endian integer |
| Key | Value |
|--------|------------------------------------------|
| `csc` | Custody subnet count, big endian integer |

0 comments on commit bd396a6

Please sign in to comment.