beacon/engine: check for empty requests #31010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
requested review from
MariusVanDerWijden,
lightclient and
fjl
as code owners
lightclient
reviewed
Jan 9, 2025
Co-authored-by: lightclient <[email protected]>
fjl
reviewed
Jan 9, 2025
beacon/engine/types.go
Outdated
| for _, req := range requests { | ||
| // No empty requests. | ||
| if len(req) < 2 { | ||
| return nil, fmt.Errorf("empty request: %v", req) |
There was a problem hiding this comment.
Do they define an error code for this?
There was a problem hiding this comment.
Just the normal invalid params error code: https://github.com/ethereum/execution-apis/pull/622/files
rjl493456442
previously approved these changes
Jan 10, 2025
lightclient
requested changes
Jan 11, 2025
There was a problem hiding this comment.
One issue with this PR is that it returns a PayloadStatusV1, status INVALID and no error -- note the return api.invalid(err, nil), nil in newPayload(..).
The PR requires clients return the error -32602: Invalid params. Usually we return this in the body of the versioned method e.g.
func (api *ConsensusAPI) NewPayloadV4(params engine.ExecutableData, versionedHashes []common.Hash, beaconRoot *common.Hash, executionRequests []hexutil.Bytes) (engine.PayloadStatusV1, error) {
...
if executionRequests == nil {
return engine.PayloadStatusV1{Status: engine.INVALID}, engine.InvalidParams.With(errors.New("nil executionRequests post-prague"))
}
}So we should either do this requests check there in the versioned method or we need to interpret the error from ExecutableDataToBlock and return invalid params from newPayload.
s1na
requested review from
holiman,
karalabe,
gballet,
zsfelfoldi and
jwasinger
as code owners
s1na
force-pushed
the
eip7685/empty-req
branch
from
3636acc to
767801a
Compare
fjl
approved these changes
Jan 15, 2025
lightclient
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#engine_newpayloadv4: