Fixing fetching RPC #515
Merged
Fixing fetching RPC #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msooseth
force-pushed
the
fix-fetching-rpc
branch
2 times, most recently
from
43a143e
to
98ac1b6
Compare
msooseth
force-pushed
the
fix-fetching-rpc
branch
from
ef267e8
to
e6285d0
Compare
msooseth
force-pushed
the
fix-fetching-rpc
branch
from
e6285d0
to
fdeeb04
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue: #490 seems to be caused by some RPC failure. This PR seems to fix it, although in ways unknown to even me.
I don't know how to check via some test that this is not accidentally broken by a later commit. This PR definitely fixes the bug with:
In the sense that RPC doesn't fail any more, which is the point here (symbolic interpretation issues are a different issue). If anyone has an idea how to write a test for this, let me know.
Checklist