Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace eth2_hashing with ethereum_hashing #1445

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

come-maiz
Copy link
Contributor

This is a necessary step to update ring, which is necessary to build in risc-v.

Part of #1444.

What was wrong?

trin fails to build in risc-v

How was it fixed?

It is still not fixed. This is just one step forward.

To-Do

@come-maiz
Copy link
Contributor Author

Thanks to @haurog and @michaelsproul for fixing the ring dependency in ethereum_hashing:
sigp/ethereum_hashing#8

@KolbyML
Copy link
Member

KolbyML commented Sep 13, 2024

@come-maiz CI is going to fail because of how you named your commit, could you amend the commits name following these guidelines https://www.conventionalcommits.org/en/v1.0.0/

@KolbyML
Copy link
Member

KolbyML commented Sep 13, 2024

chore: replace eth2_hashing with ethereum_hashing

^ something like this would be good

This is a necessary step to update ring, which is necessary to build in risc-v.

Part of ethereum#1444.
@come-maiz
Copy link
Contributor Author

Yes, done ^_^

@KolbyML
Copy link
Member

KolbyML commented Sep 13, 2024

Yes, done ^_^

Thank you for your first contribution

@KolbyML KolbyML merged commit ba63fb2 into ethereum:master Sep 13, 2024
9 checks passed
@come-maiz come-maiz deleted the replace-eth2-hashing branch September 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants