Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monorepo: add genesis to readme #3097

Merged
merged 6 commits into from
Oct 9, 2023
Merged

monorepo: add genesis to readme #3097

merged 6 commits into from
Oct 9, 2023

Conversation

gabrocheleau
Copy link
Contributor

@gabrocheleau gabrocheleau commented Oct 7, 2023 •
edited
Loading

Adds the genesis package to the readme

@gabrocheleau gabrocheleau marked this pull request as draft October 7, 2023 22:48
@codecov
Copy link

codecov bot commented Oct 7, 2023 •
edited
Loading

Codecov Report

Merging #3097 (fb9a39e) into master (9f34881) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.78% <ø> (ø)
blockchain 92.61% <ø> (ø)
client 87.60% <ø> (ø)
common 98.19% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.87% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 90.23% <ø> (ø)
trie 90.39% <ø> (ø)
tx 96.36% <ø> (ø)
util 86.97% <ø> (ø)
vm 76.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrocheleau gabrocheleau marked this pull request as ready for review October 8, 2023 04:51
scorbajio
scorbajio previously requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@scorbajio scorbajio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a genesis workflow in #3098 so that link can be added to the README for the tests column. Other than that, this looks great!

acolytec3
acolytec3 previously approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Small request for next time you do multiple doc updates, can you combine them into one so we don't have to rerun CI multiple times?

acolytec3
acolytec3 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cherrypicked the new CI job from #3098 to this branch and updated the readme. Should be ready to merge

@acolytec3 acolytec3 dismissed scorbajio’s stale review October 9, 2023 11:49

Already handled

@acolytec3 acolytec3 merged commit fc1d63b into master Oct 9, 2023
@acolytec3 acolytec3 mentioned this pull request Oct 9, 2023
Closed
@scorbajio scorbajio deleted the monorepo/add-genesis-to-readme branch October 9, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

@scorbajio scorbajio scorbajio left review comments

Assignees
No one assigned
Labels
package: genesis package: monorepo type: docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrocheleau @acolytec3 @scorbajio