Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm/tests: cleanup access to private variables + types #3149

Merged
merged 2 commits into from
Nov 7, 2023
Merged

vm/tests: cleanup access to private variables + types #3149

merged 2 commits into from
Nov 7, 2023

Conversation

jochem-brouwer
Copy link
Member

No description provided.

@jochem-brouwer jochem-brouwer added PR state: needs review type: tests package: vm type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR. labels Nov 7, 2023
@jochem-brouwer jochem-brouwer force-pushed the cleanup-vm-test-runners branch from e2296ff to 6cdc208 Compare November 7, 2023 15:13
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

Merging #3149 (e45437c) into master (c545ba0) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.80% <ø> (ø)
blockchain 92.27% <ø> (ø)
client 86.17% <ø> (+0.03%) ⬆️
common 98.19% <ø> (ø)
devp2p 86.32% <ø> (ø)
ethash ∅ <ø> (∅)
evm 71.93% <ø> (ø)
statemanager 90.13% <ø> (ø)
trie 90.13% <ø> (ø)
tx 96.36% <ø> (ø)
util 87.53% <ø> (ø)
vm 76.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

acolytec3
acolytec3 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have run the test runners locally and see no failures.

scorbajio
scorbajio approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@scorbajio scorbajio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@scorbajio scorbajio merged commit a582c7e into master Nov 7, 2023
75 checks passed
@scorbajio scorbajio deleted the cleanup-vm-test-runners branch November 7, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scorbajio scorbajio scorbajio approved these changes

@acolytec3 acolytec3 acolytec3 approved these changes

Assignees
No one assigned
Labels
package: vm PR state: needs review type: test all hardforks This special label enables VM state and blockchain tests for all hardforks on the respective PR. type: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jochem-brouwer @acolytec3 @scorbajio