Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Add more unit tests for setHead function #3814

Merged
merged 5 commits into from
Dec 20, 2024
Merged

client: Add more unit tests for setHead function #3814

merged 5 commits into from
Dec 20, 2024

Conversation

carmen0208
Copy link
Contributor

Add unit tests for PR: Implement debug_setHead #3811

  • Add more unit tests for the setHead function
  • Add RPCMethod as the return type for the middleware function.
  • Add the missing name parameters to the function definition comments.

gabrocheleau
gabrocheleau approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks a lot for this submission. Will merge in once CI passes.

gabrocheleau
gabrocheleau previously requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, type issues

scorbajio
scorbajio previously requested changes Dec 18, 2024
View reviewed changes
packages/client/test/rpc/debug/setHead.spec.ts Outdated Show resolved Hide resolved
@carmen0208 carmen0208 force-pushed the master branch 2 times, most recently from e3c6780 to 20c7836 Compare December 20, 2024 09:41
acolytec3
acolytec3 approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 dismissed stale reviews from scorbajio and gabrocheleau December 20, 2024 11:11

Comments addressed

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.57%. Comparing base (cd4afd0) to head (17ea687).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 73.74% <ø> (ø)
blockchain 83.23% <ø> (ø)
client 73.70% <100.00%> (+0.03%) ⬆️
common 89.82% <ø> (ø)
devp2p 71.95% <ø> (ø)
evm 64.60% <ø> (ø)
genesis 100.00% <ø> (ø)
mpt 52.09% <ø> (-0.04%) ⬇️
rlp 95.11% <ø> (ø)
statemanager 67.76% <ø> (ø)
tx 76.56% <ø> (ø)
util 72.81% <ø> (ø)
vm 57.02% <ø> (ø)
wallet 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3 acolytec3 merged commit d47fd8e into ethereumjs:master Dec 20, 2024
41 checks passed
@chensongIntel
Copy link

Very well done @carmen0208
😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acolytec3 acolytec3 acolytec3 approved these changes

@scorbajio scorbajio Awaiting requested review from scorbajio

@gabrocheleau gabrocheleau Awaiting requested review from gabrocheleau

Assignees
No one assigned
Labels
package: client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carmen0208 @chensongIntel @acolytec3 @gabrocheleau @scorbajio