evm: verkle testing extraction #3817
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
| historyServeWindow: 8192, // The amount of blocks to be served by the historical blockhash contract | ||
| systemAddress: '0xfffffffffffffffffffffffffffffffffffffffe', // The system address |
There was a problem hiding this comment.
Do we need to have both of these parameters since they are identical?
There was a problem hiding this comment.
I will admit that I've been a bit confused with regards to those two addresses. I've played around when troubleshooting so this is a remnant of that. I've adjusted it so that it matches the EIP: https://eips.ethereum.org/EIPS/eip-2935
| // config | ||
| historyStorageAddress: '0xfffffffffffffffffffffffffffffffffffffffe', // The address where the historical blockhashes are stored | ||
| historyStorageAddress: '0x0aae40965e6800cd9b1f4b05ff21581047e3f91e', // The address where the historical blockhashes are stored |
There was a problem hiding this comment.
Why doesn't this match the EIP 2935 address?
There was a problem hiding this comment.
Left ts as is but adjusted the eip 2935 one from evm
Co-authored-by: acolytec3 <[email protected]>
…hereumjs/ethereumjs-monorepo into evm/verkle-testing-extraction
I think all has been addressed! Ready for re-review/merge |
Ty! It seems like the PR wasn't approved, can you re-approve? thanks! |
This PR extracts some verkle work from #3716 so that the other PR can remain scoped on running verkle tests.