Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README info for node-gyp installation #671

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Add README info for node-gyp installation #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3031f3
Update README with further installation notice in case of errors
foufrix Nov 13, 2024
44e107c
Tweak language
acolytec3 Nov 13, 2024
249d60a
fix broken test
acolytec3 Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ de2f8:ultralight Started JSON RPC Server address=http://localhost:8545

This will start a single instance of the Ultralight client running locally.

### Error related to `node-gyp` or `bcrypto.node`

If you encounter errors related to `bcrypto.node` or `node-gyp` when running `npm i`, you need to add `npm i -g @mapbox/node-pre-gyp` prior to running building Ultralight.

For Mac users, you may need to run `sudo xcodebuild -license` and accept it, as `node-gyp` relies on Xcode commands.


## Connecting to the devnet (developer testnet)

1. Change active folder: `cd packages/cli`
Expand Down
2 changes: 1 addition & 1 deletion packages/portalnetwork/test/integration/beacon.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ describe('OFFER/ACCEPT tests', () => {
const acceptedOffers = await network1.sendOffer(network2.enr.nodeId, [
staleOptimisticUpdateContentKey,
])
assert.equal(acceptedOffers, undefined, 'no content was accepted by node 2')
assert.deepEqual(acceptedOffers, [], 'no content was accepted by node 2')
const content = await network2.retrieve(
hexToBytes(intToHex(BeaconLightClientNetworkContentType.LightClientOptimisticUpdate)),
)
Expand Down
Loading